RLMEnv: Make sub-LLM calls work for training#738
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align sub‑LLM requests with interleaved rollouts; tighten local RLM worker shutdown
Context
Sub‑LLM requests were hitting the wrong endpoint when interleaved rollouts are enabled, causing vLLM 400s and token accounting issues. Also, local code execution left child processes alive on teardown.
What changed
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Aligns sub‑LLM requests with main-model interleaved flow and improves local worker robustness.
interleaved_rollouts=True, tokenize viatokenize_vllmand POST to/chat/completions/tokenswith normalized sampling args; otherwise usechat.completions.create. Removes logprobs fallback logic and adds message content normalization.start_new_session=Trueand terminate viaos.killpg(.., SIGTERM/SIGKILL)to avoid orphaned children.stateinto sub‑LLM paths, useChatMessagestypes, and record sub‑LLM turns/metrics in trajectory steps.Written by Cursor Bugbot for commit abd8127. This will update automatically on new commits. Configure here.