Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
vf-evalcrashes before any event loop lag is measured, the printing of results fails because numpy cannot compute statistics over an empty list. This PR fixes this by guarding the printing, i.e. only print if >= 1 measurement has been made.Before
After
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Prevents a crash when printing evaluation results if no event loop lag measurements were collected.
verifiers/utils/eval_utils.py,print_resultsnow prints the "Performance" section only whenevent_loop_lagsis non-empty (if event_loop_lags:), avoiding numpy empty-slice statistics on an empty list.Written by Cursor Bugbot for commit e245e01. This will update automatically on new commits. Configure here.