Skip to content

Comments

Fix wiki-search#697

Merged
willccbb merged 2 commits intomainfrom
fix-wiki-search
Jan 7, 2026
Merged

Fix wiki-search#697
willccbb merged 2 commits intomainfrom
fix-wiki-search

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Jan 6, 2026

Description

Also uses ToolRubric which got deprecated. Also brings it back into CI so this would've been caught earlier (it takes 40s locally for me the run tests so I think this is better than catching regressions late)

Screenshot 2026-01-06 at 10 05 58 PM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

fix: update wiki_search to use judge-only rubric and re-enable tests

  • Removes deprecated ToolRubric/RubricGroup usage; vf.ToolEnv now receives rubric=judge_rubric only in environments/wiki_search/wiki_search.py
  • Keeps tool definitions and dataset loading unchanged; no API surface changes to tools
  • Re-enables CI coverage by unskipping wiki_search in tests/test_envs.py (it will now run in the slow env tests)

Written by Cursor Bugbot for commit 6ae79ee. This will update automatically on new commits. Configure here.

@mikasenghaas mikasenghaas requested a review from willccbb January 6, 2026 21:06
@mikasenghaas mikasenghaas marked this pull request as ready for review January 6, 2026 21:06
@willccbb willccbb merged commit ab7f056 into main Jan 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants