Skip to content

Comments

Log timings in vf-eval#686

Merged
willccbb merged 6 commits intomainfrom
log-timing
Jan 5, 2026
Merged

Log timings in vf-eval#686
willccbb merged 6 commits intomainfrom
log-timing

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Jan 5, 2026

Description

This PR adds logging for rollout times invf-eval. Logs min/mean/max recorded timings in human-readable format

uv run vf-eval math-python -n1 -r1 -v
Screenshot 2026-01-05 at 6 17 32 PM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Adds concise rollout timing stats to evaluation output.

  • In eval_utils.print_results, aggregates generation_ms, scoring_ms, and total_ms, converts to seconds, and prints min/mean/max via print_time
  • Introduces print_time in logging_utils to format seconds into human-readable strings and updates import usage

Written by Cursor Bugbot for commit 4987f9c. This will update automatically on new commits. Configure here.

@mikasenghaas mikasenghaas marked this pull request as ready for review January 5, 2026 17:19
@mikasenghaas mikasenghaas requested a review from willccbb January 5, 2026 17:19
@mikasenghaas mikasenghaas mentioned this pull request Jan 5, 2026
13 tasks
@willccbb willccbb merged commit e6253c0 into main Jan 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants