Skip to content

Comments

[Small][Bugfix] Fix Environment make_dataset method (from main README)#683

Merged
willccbb merged 1 commit intoPrimeIntellect-ai:mainfrom
pruksmhc:yadap/make-dataset-change
Jan 7, 2026
Merged

[Small][Bugfix] Fix Environment make_dataset method (from main README)#683
willccbb merged 1 commit intoPrimeIntellect-ai:mainfrom
pruksmhc:yadap/make-dataset-change

Conversation

@pruksmhc
Copy link
Contributor

@pruksmhc pruksmhc commented Jan 5, 2026

Description

Following the evaluation example in the README was throwing errors in the make_dataset step.

This PR fixes that.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
    All tests passed except for a few environment loads (due to lack of API keys).
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Fixes dataset creation errors in evaluation by adjusting method binding.

  • Convert Environment.make_dataset to a staticmethod, preventing unintended self binding and aligning with README usage

Written by Cursor Bugbot for commit 252e1f8. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2026

CLA assistant check
All committers have signed the CLA.

@willccbb willccbb merged commit d03ff7e into PrimeIntellect-ai:main Jan 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants