Conversation
samsja
approved these changes
Dec 22, 2025
59cd6d6 to
f4705b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes to
MathRubric:CancelledErrorso that timeouts don't show print warnings twicemath_verifylogs (Timeout is disabled as parsing_timeout is None or <= 0, you must provide the logic for timeout interuption yourself to prevent code getting stuck.)Also, use
MathRubricingsm8kfor testing.Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Run MathRubric parse/verify in a thread pool with proper timeout/logging, use it in gsm8k, and bump gsm8k to verifiers>=0.1.8.
verifiers/rubrics/math_rubric.py):parse/verifyviaThreadPoolExecutor(configurablemax_workers) withrun_in_executorhelper.asyncio.wait_for; re-raiseCancelledError; add warning logs on failures/timeouts; suppressmath_verifylogs.__del__.environments/gsm8k/gsm8k.py):vf.MathRubric; passrubric.parsertoSingleTurnEnv.tests/test_math_rubric.py):max_workers=1in timeout test.environments/gsm8k/pyproject.toml):0.1.3; requireverifiers>=0.1.8.Written by Cursor Bugbot for commit b50d99c. This will update automatically on new commits. Configure here.