Conversation
| from datasets import Dataset | ||
|
|
||
| import verifiers as vf | ||
| from verifiers.envs.experimental.mcp_env import MCPEnv |
There was a problem hiding this comment.
Unused python-dotenv dependency breaks .env file loading
The old mcp_env.py called load_dotenv() to automatically load environment variables from .env files, but the new mcp_search_env.py does not import or use python-dotenv despite listing it as a dependency. Users who previously relied on .env files for EXA_API_KEY will now receive a RuntimeError even with a valid .env file present. Either the dependency should be removed if .env loading is not intended, or load_dotenv() should be called before checking os.environ.get("EXA_API_KEY").
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Add new
mcp-search-envbuilt onverifiers.envs.experimental.MCPEnv, remove old in-repomcp_env, and update deps/tests accordingly.environments/mcp_search_env/withmcp_search_env.pyand README; usesverifiers.envs.experimental.MCPEnvand requiresEXA_API_KEY.environments/mcp_env/incl.mcp_env.py,mcp_server_connection.py,mcp_tool_wrapper.py,models.py) and associated output artifacts underoutputs/evals/.pyproject.tomldeps (addmath-verify,prime-sandboxes,pydantic, etc.) and includemcpinenvsoptional extras; addenvironments/mcp_search_env/pyproject.tomlwithverifiers>=0.1.8.post2andmcp>=1.0.0.tests/test_envs.pyto skipmcp_search_env(requiresEXA_API_KEY) and remove skip formcp_env..gitignoreto ignore root__pycache__/.Written by Cursor Bugbot for commit 6d7bc97. This will update automatically on new commits. Configure here.