Skip to content

Comments

option to bypass scoring#645

Merged
willccbb merged 2 commits intomainfrom
will/score-rollouts
Dec 22, 2025
Merged

option to bypass scoring#645
willccbb merged 2 commits intomainfrom
will/score-rollouts

Conversation

@willccbb
Copy link
Member

@willccbb willccbb commented Dec 20, 2025

Description

Adds score_rollouts bool as Environment class attr, with setter functions, to allow skipping scoring.

Environments can optionally reference this attr to skip scoring-only resource initialization in setup_state.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Adds a score_rollouts flag to Environment/EnvGroup to optionally skip scoring by calling Rubric.dummy_score_group instead of score_group.

  • Environment:
    • Add score_rollouts attr (default True) with set_score_rollouts; initialize via constructor.
    • In run_group, conditionally call rubric.score_group(...) or rubric.dummy_score_group(...) based on score_rollouts.
  • EnvGroup:
    • Add set_score_rollouts to propagate the flag to all sub-environments.
  • Rubric:
    • Implement dummy_score_group to set zero reward and empty metrics for rollouts.

Written by Cursor Bugbot for commit 7e7754f. This will update automatically on new commits. Configure here.

@willccbb willccbb marked this pull request as ready for review December 20, 2025 04:03
@willccbb willccbb mentioned this pull request Dec 21, 2025
13 tasks
@willccbb willccbb merged commit 0cdcdf9 into main Dec 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant