Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new component : Rating card #383

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

new component : Rating card #383

wants to merge 9 commits into from

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Oct 9, 2024

❓ Types of changes

see #382

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud
feat: [new-component] - related #382 : PuikRatingCard (wip)
216a109
@mattgoud
feat: [new-component][Rating-card] - related #382 : change deprecated…
8531ed9 
… Material Icons set to Material Symbols, add fill prop to icon component, remove useless size prop from rating-card component
@mattgoud
feat: [new-component][Rating-card] - fixed #382 : add tests and stori…
e970443 
…es + fix typos
@mattgoud mattgoud linked an issue Oct 9, 2024 that may be closed by this pull request
⭐️[new-component]-Rating Card #382
Open
@mattgoud
feat: [new-component][Rating-card] - add booleanish type and overload…
039bc7f 
… totalRatings prop for web-component use case, update storie and add tests
@mattgoud mattgoud marked this pull request as ready for review October 10, 2024 13:34
guillaume60240
guillaume60240 requested changes Oct 11, 2024
View reviewed changes
packages/components/rating-card/src/rating-card.vue
node-type="span"
/>
</div>
<PuikIcon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux passer le data test à l'icon en props

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume60240 guillaume60240 guillaume60240 approved these changes

@krimz krimz Awaiting requested review from krimz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⭐️[new-component]-Rating Card
2 participants
@mattgoud @guillaume60240