Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.1.0 #22

Merged
merged 50 commits into from
Apr 8, 2022
Merged

Release 2.1.0 #22

merged 50 commits into from
Apr 8, 2022

Conversation

Progi1984
Copy link
Member

Questions Answers
Description? Release 2.1.0
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A
Possible impacts? N/A

matks and others added 30 commits March 30, 2020 18:39
@matks
Add Pull Request template for github
b380372
@PierreRambaud
Merge pull request #10 from matks/dev
2611032 
Add GitHub PR template
@matks
Enable Release Drafter
9b8fda0
@Progi1984
Merge pull request #11 from matks/dev
31b5ea0 
Enable Release Drafter
@matks
Add CONTRIBUTORS file
a93fce8
@Progi1984
Merge pull request #12 from matks/dev
a68ecb8 
Add CONTRIBUTORS file
@matks
Update license header file index.php
f81d023
@matks
Update license header file statssales.php
70edfba
@matks
Update license header file translations/index.php
e06dcf2
@PierreRambaud
Merge pull request #13 from matks/dev
7be1260 
Fix outdated license headers
Add dependabot config file
77b02f5
@matks
Merge pull request #14 from PierreRambaud/dev
f331192 
Add dependabot config file
@matks
Update license header file index.php
2bdb2d6
@matks
Update license header file statssales.php
21c8d75
@matks
Update license header file translations/index.php
6425ece
@matks
Merge pull request #15 from matks/fix-license-headers-2
5fb2f47 
Fix license headers - part 2
@Julievrz
Update About section of README
63ede2d
@Julievrz
Update short description
844c9d4
@Julievrz
Update logo
8d71d8e
@atomiix
Merge pull request #16 from Julievrz/dev
021c98f 
Update short description and logo
@Touxten
Use the good column for total turnover
9ac563c
@Progi1984
Merge pull request #17 from okom3pom/okom3pom-fix-total
9817038 
Use the good column for total  turnover
@Hlavtox
Remove deprecated functions
507b6a0
@PierreRambaud
Merge pull request #19 from Hlavtox/remove-deprecated
0eb653d 
Replace deprecated displayPrice methods
@Progi1984
Fixed Refunds in Total Sales Calculation
1d58fb8
@Progi1984
Fetch refunds only if available
17b12ae
@PierreRambaud
Merge pull request #18 from Progi1984/issue16770
f404ec4 
Fixed Refunds in Total Sales Calculation
@Progi1984
Bump version to 2.1.0
6e7dd0c
@PierreRambaud
Merge pull request #21 from Progi1984/bumpVersion
16dee2e 
Bump version to 2.1.0
@Progi1984
Merge remote-tracking branch 'upstream/master' into mergeMaster
138418a
atomiix
atomiix previously approved these changes Mar 1, 2022
View reviewed changes
@atomiix atomiix dismissed their stale review March 1, 2022 10:50

I though for a second that #25 was merged 😅

matthieu-rolland
matthieu-rolland reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not aproving before #25 is merged)

@Progi1984
Copy link
Member Author

#25 is merged 🎉

florine2623
florine2623 reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Tested :
#16
#17
#19
#24
#25
#26
All these are QA ✅

But I'm encountering a problem while testing this one : #18
The amount after a Partial Refund is OK in Stats > Sales & Orders, but NOK in Dashboard
Screenshot 2022-04-06 at 11 38 16
Screenshot 2022-04-06 at 11 37 50

Can you check please ?
Thanks!

@Progi1984
Copy link
Member Author

@florine2623 For this last bug, you should create a new issue because it's relative to the module dashtrends.

@florine2623 florine2623 mentioned this pull request Apr 8, 2022
Closed
2 tasks
florine2623
florine2623 approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Progi1984 ,

Thanks, the issue is created here : PrestaShop/PrestaShop#28186

I haven't found any other bug nor regression on this release.
It is QA ✅

@Progi1984 Progi1984 merged commit 35a1488 into master Apr 8, 2022
@Progi1984
Copy link
Member Author

Thanks @florine2623 for this wonderful QA (and a lot of 🤯).

@Robin-Fischer-PS
Copy link

Thanks @Progi1984 @florine2623 ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@florine2623 florine2623 florine2623 approved these changes

@jolelievre jolelievre Awaiting requested review from jolelievre

@atomiix atomiix Awaiting requested review from atomiix

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.