Provide absolute URL to fix routing issues #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jul 25, 2025
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | Provide absolute URL to fix routing issues. Fixes potential issues coming from relative URLs not being reliable after symfony migration. See PrestaShop/PrestaShop#39185. cc @Touxten |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#39185 |
| Sponsor company | TRENDO s.r.o. |
| How to test? | Just test the module can be configured correctly and loads in the backoffice, so we didn't break anything or have some typo. (On nginx server, this could be problematic.) |
Touxten
approved these changes
Jul 25, 2025
ShaiMagal
approved these changes
Jul 25, 2025
|
Hello @Hlavtox, Thank you in advance for your reply. |
Contributor
Author
|
@SiraDIOP No need, if you can open and save the configuration form, it's OK. :-) The same for all PRs in PrestaShop/PrestaShop#39185 (comment) |
|
Hello @Hlavtox, It's Ok for me ^^ Thanks |
SiraDIOP
approved these changes
Aug 13, 2025
Contributor
Author
|
Thank youuuu @SiraDIOP 🥳 |
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.