Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO: Fix overlapping columns #61

Merged
merged 1 commit into from
Jun 16, 2022
Merged

BO: Fix overlapping columns #61

merged 1 commit into from
Jun 16, 2022

Conversation

hibatallahAouadni
Copy link
Contributor

Questions Answers
Description? 'Change position' label in Modules/ps_mainmenu/Configure has no enough space and next columns overlay it
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#26054.
How to test? check the issue description

@Progi1984 Progi1984 added this to the 2.3.2 milestone Jun 15, 2022
@Progi1984 Progi1984 added the bug label Jun 15, 2022
@hibatallahAouadni hibatallahAouadni requested review from a team and removed request for atomiix June 15, 2022 13:47
@florine2623 florine2623 self-assigned this Jun 16, 2022
florine2623
florine2623 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hibatallahAouadni ,

Thanks for your PR !

With PR Without PR
Screenshot 2022-06-16 at 14 51 26 Screenshot 2022-06-16 at 14 51 30

Looking good !
It is QA ✅

@Progi1984 Progi1984 merged commit 76665c0 into PrestaShop:dev Jun 16, 2022
@Progi1984
Copy link
Member

Thanks @hibatallahAouadni & @florine2623

@hibatallahAouadni hibatallahAouadni deleted the issue_26054 branch June 16, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@florine2623 florine2623 florine2623 approved these changes

@NeOMakinG NeOMakinG Awaiting requested review from NeOMakinG

Assignees

@florine2623 florine2623

Labels
bug QA ✔️
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

First column in configure main menu screen has no enough space
4 participants
@hibatallahAouadni @Progi1984 @matthieu-rolland @florine2623