Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sortable path #881

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix sortable path #881

merged 1 commit into from
Jul 28, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jul 17, 2023

Questions Answers
Description? Fixes issue with checkboxes not working on 8.1 and errors in console. _PS_JS_DIR_ is an url not a directory path, which is not very obvious without checking it's definition. define('_PS_JS_DIR_', __PS_BASE_URI__.'js/');
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#32987
How to test? Check that checkboxes stay checked after reopening the edit screen. I think this issue only happens when using prestashop in a subfolder - like localhost/dev/.

This change is Reviewable

@Hlavtox Hlavtox mentioned this pull request Jul 27, 2023
@Hlavtox Hlavtox modified the milestones: 3.13.0, 3.13.1 Jul 27, 2023
@djoelleuch djoelleuch self-assigned this Jul 28, 2023
Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

I have checked your PR the issue is well fixed ,

Untitled_.Jul.28.2023.5_25.PM.webm

It's QA approved ✔️
Thank you !

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 28, 2023

Thank you @djoelleuch :-)

@Hlavtox Hlavtox merged commit b8f58d9 into PrestaShop:dev Jul 28, 2023
12 checks passed
@Hlavtox Hlavtox deleted the fix-sortable branch July 28, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Faceted_search Filter disabled and cannot be enabled
6 participants