Add possibility to filter by discounts, on sale and new products #880

Hlavtox · 2023-07-17T07:11:32Z

Questions	Answers
Description?	Adds a new feature that allows filtering for new products, discounted products or products with "On sale" flag.
Type?	new feature
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	Try this new filter, try to upgrade the module.

Description

Adds a new feature that adds possibility to filter by some new product special things.
- You can filter out products that are new.
- You can filter out products that are discounted.
- You can filter out products that have "On sale" label on them.
I named a group of these new features "Highlights".

Screenshot

This change is

kpodemski

Only one question.

I kinda like "Highlights", but a few alternatives I see:

Products types (although it's confusing with product types like pack, combination, etc.)
Products selections
Shopping choices
Specific products

kpodemski · 2023-07-18T11:39:09Z

ps_facetedsearch.php

+
+                if (!isset($doneCategories[(int) $idCategory]['q'])) {
+                    $filterData['layered_selection_highlights'] = ['filter_type' => Converter::WIDGET_TYPE_CHECKBOX, 'filter_show_limit' => 0];
+                    $doneCategories[(int) $idCategory]['e'] = true;


e like "extra properties"? 🤔

Yep, forgotten

MatShir

Small request: We should separate the new and the discounts part 🙏

kpodemski · 2023-07-19T07:04:09Z

@MatShir what do you mean? it is about showing products with different state, on discount, on sale, new products - how would you like to split this?

l-delin · 2023-07-19T14:16:59Z

Hello @Hlavtox :-)

As @MatShir said, it would be nice to have two separate parts for the two "types" of labels so it's not too confusing. By that, I mean that Discounted & On sale products should not be in the same section as New products, because they don't share common properties.
I liked your proposition with the use of "highlights" but in an ecommerce context, it doesn't work. We need to use words users are familiar with.
There's a second point: how can we translate it? It works fine in English, but for languages like French, you'd need to split it into two words and it would take too much space.

So, considering this, here's what we propose:

Instead of the Highlights category, two categories: Deals and Selection.

The Deals section is dedicated to Discounted and On sale products.
And, as a personal suggestion: Ultimately, "Flash sales" could be added to this category as well.

The Selection section contains a selection of specific products. In this case, the New products category.
Again, suggestion: categories such as season-themed or holiday-themed product collections could be added to this category. (e.g.: "Christmas collection", "Summer collection", etc.)

So it would look like this:

Deals:

Discounted
On Sale

Selection:

New products

What do you think? 🏎

src/Adapter/MySQL.php

src/Product/SearchProvider.php

Hlavtox · 2023-09-27T12:31:27Z

@MatShir @kpodemski It's ready for review.

I went for facet name "Selections" and putting three values there. After Slack discussion, it doesn't make sense to have a separate category with one filter.
This filter is now enabled on new module install. For existing users, it's not.
When installing this module, I moved the stock, price and selections filter to the top. As they are the most important.
The filters work like this, if enabled - ((On sale OR Discounted) AND New product)

How it looks

MatShir · 2023-09-27T12:44:08Z

Looks good to me !

florine2623

Hello @Hlavtox ,

Tested on 8.0.x, 8.1.x and develop branches.

Upgrade to 3.14.0 OK ✅

New filter Selections works fine ^^

There's just this option that I do not have :
When installing this module, I moved the stock, price and selections filter to the top. As they are the most important.

Could you check ? ^^

Hlavtox · 2023-10-04T14:31:43Z

Hi @florine2623, it works only on clean installs when there never was faceted search. For existing installs, there will be no change.

florine2623

@Hlavtox ,

Indeed after Uninstalling the module and reinstalling with the PR, the 3 elements are on top the the filter list ^^

QA ✅
Thanks!

kpodemski · 2023-10-04T17:57:19Z

well done 👏🏻 thanks @Hlavtox

MatShir · 2023-10-05T15:09:19Z

Hi @florine2623, it works only on clean installs when there never was faceted search. For existing installs, there will be no change.

Even after a module upgrade ? what needs to be done for this part to be on top ? @Hlavtox

Hlavtox changed the title ~~Add highlights feature~~ Add possibility to filter by discounts, on sale and new products Jul 17, 2023

Hlavtox force-pushed the extras branch 5 times, most recently from 6218850 to 263ed3a Compare July 17, 2023 12:01

Hlavtox marked this pull request as ready for review July 17, 2023 12:32

Hlavtox force-pushed the extras branch 2 times, most recently from d961aa5 to 263ed3a Compare July 18, 2023 09:15

kpodemski reviewed Jul 18, 2023

View reviewed changes

MatShir suggested changes Jul 18, 2023

View reviewed changes

ps-jarvis added the waiting for author Waiting for author's feedback label Jul 18, 2023

MatShir added the waiting for wording label Jul 18, 2023

Hlavtox force-pushed the extras branch 4 times, most recently from 2e9c1fe to 457d2f0 Compare August 3, 2023 05:54

Hlavtox commented Aug 3, 2023

View reviewed changes

src/Adapter/MySQL.php Show resolved Hide resolved

Hlavtox commented Aug 3, 2023

View reviewed changes

src/Adapter/MySQL.php Show resolved Hide resolved

Hlavtox commented Aug 3, 2023

View reviewed changes

src/Product/SearchProvider.php Outdated Show resolved Hide resolved

Hlavtox force-pushed the extras branch 3 times, most recently from 8a87f43 to 14190cb Compare September 16, 2023 15:52

Hlavtox force-pushed the extras branch 2 times, most recently from 6f56bf0 to 946ca0e Compare September 27, 2023 11:40

Add selections feature

c6a1455

Hlavtox force-pushed the extras branch from 946ca0e to c6a1455 Compare September 27, 2023 12:23

Hlavtox removed the waiting for author Waiting for author's feedback label Sep 27, 2023

Hlavtox removed the waiting for wording label Sep 27, 2023

Hlavtox requested a review from a team October 3, 2023 08:24

MatShir approved these changes Oct 3, 2023

View reviewed changes

boherm approved these changes Oct 3, 2023

View reviewed changes

ps-jarvis added the Waiting for QA label Oct 3, 2023

florine2623 self-assigned this Oct 4, 2023

florine2623 reviewed Oct 4, 2023

View reviewed changes

florine2623 added waiting for author Waiting for author's feedback and removed Waiting for QA labels Oct 4, 2023

florine2623 removed their assignment Oct 4, 2023

florine2623 approved these changes Oct 4, 2023

View reviewed changes

ps-jarvis added the Waiting for QA label Oct 4, 2023

florine2623 self-assigned this Oct 4, 2023

florine2623 added QA ✔️ and removed Waiting for QA waiting for author Waiting for author's feedback labels Oct 4, 2023

kpodemski added this to the 3.14.0 milestone Oct 4, 2023

kpodemski merged commit d8c8f50 into PrestaShop:dev Oct 4, 2023
11 checks passed

Hlavtox mentioned this pull request Mar 5, 2024

Update default catalog 8.1.x PrestaShop/PrestaShop#35534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to filter by discounts, on sale and new products #880

Add possibility to filter by discounts, on sale and new products #880

Hlavtox commented Jul 17, 2023 •

edited

Loading

kpodemski left a comment

kpodemski Jul 18, 2023

Hlavtox Jul 18, 2023

MatShir left a comment

kpodemski commented Jul 19, 2023

l-delin commented Jul 19, 2023

Hlavtox commented Sep 27, 2023

MatShir commented Sep 27, 2023

florine2623 left a comment

Hlavtox commented Oct 4, 2023

florine2623 left a comment •

edited

Loading

kpodemski commented Oct 4, 2023

MatShir commented Oct 5, 2023

Add possibility to filter by discounts, on sale and new products #880

Add possibility to filter by discounts, on sale and new products #880

Conversation

Hlavtox commented Jul 17, 2023 • edited Loading

Description

Screenshot

kpodemski left a comment

Choose a reason for hiding this comment

kpodemski Jul 18, 2023

Choose a reason for hiding this comment

Hlavtox Jul 18, 2023

Choose a reason for hiding this comment

MatShir left a comment

Choose a reason for hiding this comment

kpodemski commented Jul 19, 2023

l-delin commented Jul 19, 2023

Hlavtox commented Sep 27, 2023

MatShir commented Sep 27, 2023

florine2623 left a comment

Choose a reason for hiding this comment

Hlavtox commented Oct 4, 2023

florine2623 left a comment • edited Loading

Choose a reason for hiding this comment

kpodemski commented Oct 4, 2023

MatShir commented Oct 5, 2023

Hlavtox commented Jul 17, 2023 •

edited

Loading

florine2623 left a comment •

edited

Loading