Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stub, ModuleCore can't return Module instance #61

Merged
merged 1 commit into from
May 12, 2021
Merged

Fix stub, ModuleCore can't return Module instance #61

merged 1 commit into from
May 12, 2021

Conversation

PierreRambaud
Copy link
Contributor

Questions Answers
Description? Stubs files are no analyzed: https://phpstan.org/user-guide/stub-files#:~:text=Stub%20files%20are%20analysed%20independently,the%20problem%20of%20optional%20dependencies. And Abstract class can't return an instance of parent class because it's not defined yet.
Type? bug fix
BC breaks? no
Deprecations? no

@Progi1984 Progi1984 merged commit ed7af69 into PrestaShop:3.x May 12, 2021
@Progi1984
Copy link
Member

Thanks @PierreRambaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants