Css compatibility #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ga-devfront
approved these changes
Jul 18, 2023
Collaborator
ga-devfront
left a comment
ga-devfront
left a comment
There was a problem hiding this comment.
Really nice work, after checking all the things it's all good for me, I got just one suggestion.
Collaborator
There was a problem hiding this comment.
I think it would me good to make the same change from example/bootstrap-4.html to see more easily the difference between us.
Collaborator
Author
There was a problem hiding this comment.
Ok, I will add these changes on this page too 👍
ga-devfront
approved these changes
Jul 19, 2023
Collaborator
ga-devfront
left a comment
ga-devfront
left a comment
There was a problem hiding this comment.
Perfect thank you for your amazing work !
example/bootstrap-5.html
Outdated
| </script> | ||
| </body> | ||
|
|
||
| </html> No newline at end of file |
Collaborator
There was a problem hiding this comment.
required new line at end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.