Skip to content

experimenting with a dockerfile #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 18, 2023
Merged

experimenting with a dockerfile #80

merged 11 commits into from
Feb 18, 2023

Conversation

Preocts
Copy link
Owner

@Preocts Preocts commented Feb 17, 2023

some interesting learning points here. Installing requirements and optional requirements are best done before the copy of files over. this allows docker to cache the step making the build faster. pyproject.toml does not support installing these separately.

  • pull the requirement files out into *.in and *.txt files compiled with pip-compile
  • adjust Makefile to account for new requirement locations
  • remove init from Makefile; it does not need to be a thing
  • pyproject.toml pulls all requirement files dynamically
  • remove pre-commit from tox env, does not feel like it belonged there
  • the readme needs to be redone

@Preocts Preocts self-assigned this Feb 18, 2023
@Preocts Preocts merged commit c0212ab into main Feb 18, 2023
@Preocts Preocts deleted the preocts branch February 18, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant