Add Deployment Logging Tutorial #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 81 81
Lines 5030 5030
=======================================
Hits 4694 4694
Misses 336 336
|
cicdw
commented
Apr 17, 2019
| @@ -577,7 +577,7 @@ def check_task_is_cached(self, state: State, inputs: Dict[str, Result]) -> State | |||
| state._result = state._result.to_result() | |||
| return state | |||
| else: | |||
| self.logger.debug( | |||
| self.logger.warning( | |||
There was a problem hiding this comment.
Open to push back on this change; it will always happen eventually, but knowing when it happens seems important so I elevated this log level to "WARNING".
joshmeek
reviewed
Apr 17, 2019
jlowin
reviewed
Apr 18, 2019
|
|
||
| ## An Example | ||
|
|
||
| Let's walk through a basic example. To begin, we will create a dummy webserver on our local machine that we will POST logs to: |
jlowin
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR adds a "Deployment: Logging" tutorial for explaining how to interact with Prefect logs (Part 2 in a series on Deployment related information).
Why is this PR important?
Is functionality really present if it isn't documented well? 🤔