Fix as_task bug #896
Merged
Fix as_task bug #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
previously approved these changes
Apr 4, 2019
3 tasks
joshmeek
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)What does this PR change?
This PR fixes our
as_taskutility for auto-converting python objects to Prefect Tasks, specifically for callables and dictionaries. Closes #894Why is this PR important?
as_taskis used internally to track all task dependencies, including constants. This utility was implicitly assuming that dictionaries were only keyed by strings and also would attempt to convert all callables intoFunctionTasks. This isn't actually possible because python builtins cannot be inspected viainspect.getfullargspecand consequently users were seeing errors when passing these types of objects around in their Flow.