Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename docker modules to avoid conflict #8788

Merged
merged 2 commits into from
May 25, 2023
Merged

Rename docker modules to avoid conflict #8788

merged 2 commits into from
May 25, 2023

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Mar 13, 2023 •
edited
Loading

Closes #6519

  • prefect.infrastructure.docker renamed to prefect.infrastructure.container
  • prefect.docker renamed to prefect.utilities.dockerutils

@zanieb zanieb requested a review from a team as a code owner March 13, 2023 19:18
@netlify
Copy link

netlify bot commented Mar 13, 2023 •
edited
Loading

✅ Deploy Preview for prefect-docs ready!

Name Link
🔨 Latest commit 33e643a
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs/deploys/6410ebb2ea88120007fb50b7
😎 Deploy Preview https://deploy-preview-8788--prefect-docs.netlify.app/api-ref/prefect/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb marked this pull request as draft March 13, 2023 19:19
serinamarie
serinamarie approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@serinamarie serinamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤠

@Pierre-VF
Copy link

Do you already know when this will be merged? (we're having many problems with this in our production setup at the moment)
Or is there a plan to solve it in another manner? (I am unsure about what the "Deprecated" tag means, given that there isn't extra information about it in the thread)

@zanieb zanieb mentioned this pull request Apr 18, 2023
Open
4 tasks
@zanieb
Copy link
Contributor Author

zanieb commented Apr 26, 2023

@Pierre-VF this needs more work to be completed.

The old module path (that is causing problems) is deprecated. This retains backwards compatibility for other users, but we've moved it to a new path to resolve the issues.

The Docker worker also should resolve this problem https://prefecthq.github.io/prefect-docker/worker/

@zanieb zanieb marked this pull request as ready for review May 25, 2023 15:22
@netlify
Copy link

netlify bot commented May 25, 2023 •
edited
Loading

✅ Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 2bc58c9
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/646f7d7e4040ae0008595287
😎 Deploy Preview https://deploy-preview-8788--prefect-docs-preview.netlify.app/api-ref/prefect/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb merged commit 8d1c4cc into main May 25, 2023
@zanieb zanieb deleted the docker-rename branch May 25, 2023 16:04
@taljaards taljaards mentioned this pull request Sep 14, 2023
Merged
5 tasks
@desertaxle desertaxle mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serinamarie serinamarie serinamarie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent fatal error running deployment with docker infra
3 participants
@zanieb @Pierre-VF @serinamarie