Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finesse a few things for smoother integration with Cloud #630

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Finesse a few things for smoother integration with Cloud #630

merged 3 commits into from
Feb 8, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 8, 2019 •
edited
Loading

This PR makes a few minor changes along its interface with Cloud:

  • Client GET requests now ship data in params instead of the request body
  • Client create_flow_run now returns a simple string ID instead of a GraphQLResult object
  • the default result handler service is updated with a result-handler route
  • CloudResultHandler.result_handler_service is now read from config at init, instead of at first action

@cicdw cicdw requested review from jlowin and joshmeek as code owners February 8, 2019 00:42
@cicdw cicdw merged commit 47146f4 into master Feb 8, 2019
@cicdw cicdw deleted the integration-finesse branch February 8, 2019 02:01
zanieb pushed a commit that referenced this pull request Feb 10, 2022
@cicdw
Merge pull request #630 from PrefectHQ/docs-for-release-2.0a424242
b97c131 
Publish docs from release 2.0a424242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin approved these changes

@joshmeek joshmeek Awaiting requested review from joshmeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdw @jlowin