-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more hooks to FlowRunner.initialize_run() #548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
previously approved these changes
Jan 22, 2019
cicdw
requested changes
Jan 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some doc changes requested
cadd7db
to
7751033
Compare
cicdw
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I approve
joshmeek
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
appropriatelyDepends on #546
What does this PR change?
FlowRunner.initialize_run()
:task_states
andtask_contexts
. This gives theinitialize_run
method an opportunity to modify task-specific inputs. In this PR, it is only used to put some items in context (such as the task name and id)FlowRunner.initialize_run
andTaskRunner.initialize_run
-- this is simply a convenience to make it easier to statically type the library and access returned valuesWhy is this PR important?
This PR stands alone by providing improved opportunity to interact with task states and contexts before a flow runs, but will mainly be used in a forthcoming PR that loads all task states from Cloud in a single call before the Flow runs. These hooks will make it possible to provide those states to the tasks.