Refactor environment build() method #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
changed the title
cicdw
requested changes
Dec 12, 2018
cicdw
previously approved these changes
Dec 12, 2018
joshmeek
reviewed
Dec 12, 2018
src/prefect/environments.py
Outdated
| - registry_url (str, optional): The registry to push the image to | ||
| - python_dependencies (list, optional): The list of pip installable python packages | ||
| that will be installed on build of the Docker container | ||
| - secrets (list, optional): A list of secret value names to be loaded into the environment | ||
| - flow_id (str, optional): A consistent flow ID (generally set on build and not passed in) | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| image: str, |
joshmeek
approved these changes
Dec 12, 2018
jlowin
changed the title
jlowin
added
enhancement
|
Marking as |
jlowin
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two principal changes:
Previously, environments were a little complex and mutated themselves when they were built, which had the potential to lead to statefulness bugs (if an environment were built twice, for example). Now, they are purely functional classes that are instantiated with any known values and produce dynamic values as a
keywhen theirbuild()method is called. In order to run the environment, the dynamickeyis passed to therun()method, where it is combined with static attributes to manipulate the flow.Note to @joshmeek this will slightly affect the GQL call that the deploy agent needs to make to collect the data it requires