Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Webhook change entry #3095

Merged
merged 1 commit into from
Aug 6, 2020
Merged

update Webhook change entry #3095

merged 1 commit into from
Aug 6, 2020

Conversation

jameslamb
Copy link

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

Changes the changelog entry for #3000 from enhancement to feature.

Why is this PR important?

Sorry! Re-reading https://github.com/PrefectHQ/prefect/blob/master/changes/README.md, I think that on #3000 I should have called that change a feature instead of an enhancement. This PR proposes a change that will make the next release's changelog slightly more accurate.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #3095 into master will not change coverage.
The diff coverage is n/a.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% agreed - thanks @jameslamb !

@cicdw cicdw merged commit d31e5b0 into PrefectHQ:master Aug 6, 2020
@jameslamb jameslamb deleted the fix/change branch September 15, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants