Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customization of the yaml template #3046

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

emcake
Copy link

@emcake emcake commented Jul 28, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Add an extra configurable YAML_TEMPLATE argument to the KubernetesAgent to allow overwriting of the template job spec.

Why is this PR important?

Due to environmental setup of our k8s cluster I found myself needing to alter the podspec run in ways not exposed by current environment variables, and it didn't seem sensible to add new environment variables for every change I'd want to make to the template. This approach allows me to build a custom container with a specialized yaml spec.

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @emcake! 🎉 🎉

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #3046 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@joshmeek
Copy link

Hi @emcake it looks like your local git may not be authenticated with your GitHub account! Generally you can see this when your commits show up as the grey octocat logo.

If you want to resolve this (and attribute the commits to yourself) you could try options like this:

Other than that could you also run black . over your branch for formatting and add this enhancement to the /changes directory 🙂

@joshmeek joshmeek merged commit 766deb6 into PrefectHQ:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants