Revert back to using relative paths in generated Dockerfile on Windows #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrefectHQ#2390 introduced a change so that on Windows, Dockerfile contained absolute paths which prevents docker build from working when using wsl backend or ssh (seehttps://github.com/PrefectHQ/issues/3023). The fix here is to use relative paths in Dockerfile while passing absolute path to client.build.
pravindahal
requested review from
jcrist,
joshmeek and
lauralorenz
as code owners
|
Here I am, brain the size of a planet and they ask me to welcome you to Prefect. So, welcome to the community @pravindahal! 🎉 🎉 |
3 tasks
pravindahal
changed the title
|
Thanks for the PR @pravindahal! While the code appears fine I don't have a windows environment to give this a test just yet so maybe someone can verify? |
|
Hi @pravindahal @joshmeek for what it's worth, I just tried out the test case back from #2332 but using this branch on regular Windows 10 AND MacOS and had no issues, so since @pravindahal can confirm it works for wsl/ssh I think we are good. |
|
also cc'ing @thomasfrederikhoeck in case they want to check |
|
@lauralorenz I will check it within a couple of hours |
|
LGTM 👍 |
joshmeek
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)What does this PR change?
#2390 introduced a change so that on Windows, Dockerfile contained absolute paths which prevents docker build from working when using wsl backend or ssh (see #3023).
The fix here is to use relative paths in Dockerfile (i.e. revert to behavior before #2390) but pass absolute path of Dockerfile to
client.build.For previous attempt at addressing this problem, see the discussion here: #3035