Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Webhook storage (fixes #2835) #3000

Merged
merged 21 commits into from
Aug 4, 2020
Merged

Add Webhook storage (fixes #2835) #3000

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
541b1c1
Add WebHook storage (fixes #2835)
jameslamb Jul 20, 2020
9bafd61
update LocalAgent tests
jameslamb Jul 20, 2020
32ff9e3
cleaning up docs
jameslamb Jul 20, 2020
8ca588d
fix typehint and add changes entry
jameslamb Jul 20, 2020
b4f5537
tell mypy to trust me
jameslamb Jul 20, 2020
e98b62f
add test for uncovered line
jameslamb Jul 20, 2020
1a3b94d
fix typos
jameslamb Jul 20, 2020
849a53f
Merge branch 'master' into feat/webhook-storage
jameslamb Jul 24, 2020
59bcc06
add support for stored_as_script
jameslamb Jul 27, 2020
8c0e32d
WebHook -> Webhook
jameslamb Jul 27, 2020
1b535f3
Merge branch 'master' into feat/webhook-storage
jameslamb Jul 28, 2020
3646336
merge master
jameslamb Jul 28, 2020
495372f
fix tests, merge master
jameslamb Jul 28, 2020
8a2b474
Merge branch 'master' into feat/webhook-storage
jameslamb Jul 29, 2020
ba6956a
Merge branch 'master' into feat/webhook-storage
jameslamb Aug 1, 2020
0add059
add _request to keyword args
jameslamb Aug 1, 2020
937dd84
replace secret_config with templating
jameslamb Aug 2, 2020
a2d40a1
linting
jameslamb Aug 2, 2020
5d29ff8
Merge branch 'master' into feat/webhook-storage
jameslamb Aug 3, 2020
85a7751
Merge branch 'master' into feat/webhook-storage
jameslamb Aug 4, 2020
921e387
remove deepcopy
jameslamb Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typehint and add changes entry
  • Loading branch information
@jameslamb
jameslamb committed Jul 20, 2020
commit 8ca588df58d85afd23cd628eb7a3016552c074b8
5 changes: 5 additions & 0 deletions changes/pr3000.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
enhancement:
- "Add WebHook storage - [#3000](https://github.com/PrefectHQ/prefect/pull/3000)"

contributor:
- "[James Lamb](https://github.com/jameslamb)"
2 changes: 1 addition & 1 deletion src/prefect/serialization/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class Meta:
secrets = fields.List(fields.Str(), allow_none=True)

@post_load
def create_object(self, data: dict, **kwargs: Any) -> GitHub:
def create_object(self, data: dict, **kwargs: Any) -> WebHook:
flows = data.pop("flows", dict())
base_obj = super().create_object(data)
base_obj.flows = flows
Expand Down