Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor agent enhancements #2744

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Some minor agent enhancements #2744

merged 4 commits into from
Jun 15, 2020

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Jun 8, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #2547
Closes #2721
Closes #2633

You can now set imagePullPolicy and ServiceAccount name on jobs created by the k8s agent. Also adds the option to set --api on prefect agent start (previously was only on install)

@joshmeek joshmeek added enhancement An improvement of an existing feature agent labels Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #2744 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Copy link

@lauralorenz lauralorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

FYI I gave it a try by taking a look at the yaml output particularly for the environment variables config from prefect agent install kubernetes --service-account-name=woah --image-pull-policy=yo --backend sup, and then also by running a kubernetes agent locally, first with no local IMAGE_PULL_POLICY env var, and then where my local IMAGE_PULL_POLICY=Always, and saw that the jobs and their pods started up in my tenant with IfNotPresent (the new default) and Always in their yaml, respectively, as rendered in google cloud console. 👍

At first I was a lil weirded out that the image pull policy default from our side was changing but I see that IfNotPresent is actually the normal kubernetes default, so this is more in line with that. Especially if this goes in with 0.12.0 then no concerns there.

@joshmeek joshmeek merged commit 2651817 into master Jun 15, 2020
@joshmeek joshmeek deleted the agent_enhancements branch June 15, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
2 participants