-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DbtShellTask #2526
DbtShellTask #2526
Conversation
Thanks for the contribution @mhmcdonald! Awesome to see DBT get some first-class representation |
Weird test failures 🤔all look to be related to logging in some way. I attempted to reproduce using this branch on a fresh conda env but everything was passing for me locally. cc @cicdw any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requests for test hygene changes -- this is great though! I have a feeling this is going to be a very popular task
@mhmcdonald I think we've narrowed down why logging related tests are failing on this branch. It appears that the # redirect stdlib logging to logbook
_redirect_std_logging() which in the tests is causing all logs to be redirected elsewhere. Since the from shutil import which
if which("dbt"):
# good to go If updated we can see if this resolves the test failures 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
from shutil import which | ||
import pytest | ||
|
||
if not which("dbt"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever
Ensure IntervalSchedules have timezones
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Adds a DbtShellTask, an extension of the ShellTask, to the task library. This task is intended for working with dbt
Why is this PR important?
The dbt community is very strong and growing in the cloud data warehousing space. There is a lot of potential overlap between the prefect and dbt communities.