Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#2439 prefect server telemetry #2467

Merged
merged 13 commits into from
May 12, 2020

Conversation

dylanbhughes
Copy link
Contributor

@dylanbhughes dylanbhughes commented May 1, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR closes #2467 and adds some minimal telemetry to Prefect Server.

Why is this PR important?

This is the first step into collecting usage information that can help the Prefect team understand how Prefect Server is being used and how we can make it better.

@dylanbhughes dylanbhughes force-pushed the feature/#2439-prefect-server-telemetry branch from b841a1a to fc3b512 Compare May 1, 2020 22:32
@dylanbhughes dylanbhughes self-assigned this May 1, 2020
@dylanbhughes dylanbhughes marked this pull request as ready for review May 1, 2020 22:37
@dylanbhughes dylanbhughes requested a review from jcrist May 1, 2020 22:37
@dylanbhughes dylanbhughes added dependencies enhancement An improvement of an existing feature labels May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #2467 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems fine to me from an implementation standpoint. We may want to hold off on merging this until whatever backend infrastructure for managing these events is finalized.

dylanbhughes and others added 2 commits May 11, 2020 09:51
Co-authored-by: Jim Crist-Harif <jcrist@users.noreply.github.com>
Co-authored-by: Jim Crist-Harif <jcrist@users.noreply.github.com>
@dylanbhughes
Copy link
Contributor Author

Once https://github.com/PrefectHQ/sens-o-matic/pull/8 is merged this should be good to go

@dylanbhughes dylanbhughes requested a review from cicdw May 11, 2020 21:14
@dylanbhughes dylanbhughes requested a review from jcrist May 11, 2020 21:14
@dylanbhughes dylanbhughes assigned cicdw and unassigned dylanbhughes May 12, 2020
@dylanbhughes
Copy link
Contributor Author

Assigning to @cicdw since I don't have permissions to merge

@cicdw cicdw merged commit 185f443 into master May 12, 2020
@cicdw cicdw deleted the feature/#2439-prefect-server-telemetry branch May 12, 2020 13:47
abrookins pushed a commit that referenced this pull request Jul 27, 2022
Disable signal handling for telemetry tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants