Minor secrets refactor #2302
Merged
Minor secrets refactor #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
commented
Apr 9, 2020
| @@ -29,7 +29,7 @@ These changes are available in the [master branch](https://github.com/PrefectHQ/ | |||
|
|
|||
| ### Breaking Changes | |||
|
|
|||
| - None | |||
| - Remove `env_var` initialization from `EnvVarSecret` in favor of `name` - [#2302](https://github.com/PrefectHQ/prefect/pull/2302) | |||
There was a problem hiding this comment.
Note that I don't believe anyone is actually using this task, as it's more of a nice example than a truly useful thing.
joshmeek
reviewed
Apr 9, 2020
joshmeek
approved these changes
Apr 10, 2020
zanieb
added a commit
that referenced
this pull request
Jul 19, 2022
Update flow and task calls to return results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR does a few things:
env_varas a distinct option fromEnvVarSecretWhy is this PR important?
This PR was originally motivated by our work on Results (additional PR for
SecretResultincoming), and I went ahead and changed the names as well as this has been a common source of confusion.