Sssshhhhh dask #226
Merged
Sssshhhhh dask #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
requested changes
Sep 27, 2018
src/prefect/config.toml
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| # the location of the user's config file | |||
| user_config_path = "$HOME/.prefect/config.toml" | |||
| dev_mode = false | |||
There was a problem hiding this comment.
I have a weak opinion that this should be called "debug" rather than "dev_mode" because I can imagine asking people to set Prefect to "debug" in order to submit proper error reports (with logs) or running remote executions in debug mode.
Also, I didn't know this until just now, but TOML supports root-level args, so my vote is actually to move this key "above" the [general] section so it becomes accessed as prefect.config.debug. This has a side benefit that entering debug mode has a really clean env var setting: PREFECT__DEBUG=true.
jlowin
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209 by adding a new
debugkwarg to theDaskExecutor. Those dangling streams are not performance related and don't impact results in any way, so this PR silences them for your typical user unless explicitly requested through eitherdebug=Trueordev_mode=Truein your config.dev_modemight also be a useful construct for other bits of functionality, too.Note: there will still be some logging in the tests, because a raw Client object is created for the fixtures. This is good because it reminds us that they're there.