Forward pod logs for crashed K8s runs that never connected#21134
Open
desertaxle wants to merge 5 commits intomainfrom
Open
Forward pod logs for crashed K8s runs that never connected#21134desertaxle wants to merge 5 commits intomainfrom
desertaxle wants to merge 5 commits intomainfrom
Conversation
When a Kubernetes pod crashes before the flow run process establishes connectivity to the Prefect server (e.g., OOMKilled during import, bad entrypoint, missing dependencies), no logs are sent to Prefect. The observer now fetches and forwards container logs for these runs so users can diagnose failures directly from Prefect. Key behaviors: - Fetches logs eagerly before the 30s reschedule-wait loop to avoid losing them to cluster GC (ttlSecondsAfterFinished) - Scopes pod lookup to the failing job via job-name label - Prioritizes the prefect-job container, falls back to first container for custom manifests, skips sidecars when primary has output - Sorts retry pods newest-first so the final attempt survives truncation - Excludes Succeeded pods, includes Running pods (restartPolicy: OnFailure) - Tries previous container instance first for restarted containers - Only forwards logs after the Crashed state proposal is accepted - Respects PREFECT_LOGGING_TO_API_MAX_LOG_SIZE with truncation - Controlled by observer.forward_crashed_run_logs (default True) and observer.forward_crashed_run_logs_tail_lines (default 500) settings Closes OSS-7760 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e check Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Instead of concatenating all container output into a single large log entry, send each line as its own flow run log record for cleaner formatting in the Prefect UI. Container headers are emitted at INFO level, log lines at ERROR level. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
desertaxle
requested review from
chrisguidry,
cicdw and
zzstoatzz
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 985437014e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/integrations/prefect-kubernetes/prefect_kubernetes/observer.py
Outdated
Show resolved
Hide resolved
When no container named prefect-job exists (custom job manifest), we cannot reliably distinguish the flow container from sidecars. Instead of guessing based on spec ordering, include logs from all containers so the actual traceback is never suppressed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observer.forward_crashed_run_logs(defaultTrue) andobserver.forward_crashed_run_logs_tail_lines(default500) settings toKubernetesObserverSettingsjob-namelabel, excludesSucceededpods, sorts newest-firstprefect-jobcontainer, falls back to first container for custom manifests, skips sidecars when primary has outputprevious=True) forrestartPolicy: OnFailurescenarios🤖 Generated with Claude Code