Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate prefect job imagePullSecrets if provided #1982

Merged
merged 4 commits into from
Feb 4, 2020

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Feb 4, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Previously providing an image_pull_secrets to the Kubernetes agent install did not automatically use them for the jobs created by the agent.

Why is this PR important?

This reduces user need to manually update the yaml outputted by the install command.

@joshmeek joshmeek merged commit d4ec0ca into master Feb 4, 2020
@joshmeek joshmeek deleted the imgpulsecrets_populate branch February 4, 2020 23:11
zanieb added a commit that referenced this pull request Jun 7, 2022
Adds missing block type name mapping to migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants