Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task for kicking off a flow run #1871

Merged
merged 13 commits into from
Dec 23, 2019
Merged

Add task for kicking off a flow run #1871

merged 13 commits into from
Dec 23, 2019

Conversation

zdhughes
Copy link

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds a task to the library for kicking off a flow run in Cloud.

Why is this PR important?

We have semi-frequent questions about how to kick off a flow from another flow. This task is a lightweight first step for addressing this.

@linear
Copy link

linear bot commented Dec 19, 2019

CLOUD-565 Create FlowRunTask in Core

@zdhughes zdhughes changed the title Add task to kick off a flow run Add task for kicking off a flow run Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019 •
edited
Loading

Codecov Report

Merging #1871 into master will increase coverage by 0.02%.
The diff coverage is 100%.

cicdw
cicdw requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor tweaks 👍

@zdhughes zdhughes requested a review from cicdw December 19, 2019 20:33
jlowin
jlowin requested changes Dec 19, 2019
View reviewed changes
@zdhughes zdhughes requested a review from jlowin December 19, 2019 21:01
@zdhughes zdhughes requested a review from jlowin December 19, 2019 21:52
jlowin
jlowin previously approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joshmeek
joshmeek previously approved these changes Dec 20, 2019
View reviewed changes
@zdhughes @cicdw
Update src/prefect/tasks/cloud/flow_run.py
a61714a 
Co-Authored-By: Chris White <chris@prefect.io>
@cicdw cicdw merged commit 6c0ddb9 into master Dec 23, 2019
@cicdw cicdw deleted the zachary/cloud-565-create-flowruntask-in-core branch December 23, 2019 14:42
zanieb pushed a commit that referenced this pull request Jun 7, 2022
@peytonrunyan
Merge pull request #1871 from PrefectHQ/add-delete-command
97f9145 
Add flow-run delete command
@CarlosEdoardo CarlosEdoardo mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@joshmeek joshmeek joshmeek approved these changes

@jlowin jlowin jlowin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zdhughes @jlowin @cicdw @joshmeek