Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging to Cloud more robust in the face of a bad log #1845

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Dec 13, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR ensures that a single bad non-JSON serializable log doesn't prevent further logs from arriving in Cloud.

Why is this PR important?

A user was attempting to log bytes from a subprocess, and all logs stopped arriving in Cloud (because bytes aren't JSON serializable). This is undesirable behavior, and as many logs as possible should be getting through.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1845 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1845 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@cicdw cicdw merged commit 5105b6b into master Dec 13, 2019
@cicdw cicdw deleted the resilient-logs branch December 13, 2019 18:01
zanieb pushed a commit that referenced this pull request Jun 7, 2022
Add API versioning contribution guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants