-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefect yaml triggers add description. #16944
base: main
Are you sure you want to change the base?
Prefect yaml triggers add description. #16944
Conversation
CodSpeed Performance ReportMerging #16944 will not alter performanceComparing Summary
|
…-from-prefect-yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! could you add one more test that confirms the description makes it to the API? (or augment an existing test)
…ct-yaml' of https://github.com/PrefectHQ/prefect into jean/oss-6107-propagate-trigger-descriptions-from-prefect-yaml
@@ -5815,6 +5818,7 @@ async def test_yaml_file_trigger(self, docker_work_pool): | |||
|
|||
trigger_spec = { | |||
"enabled": True, | |||
"description": "This is a test trigger", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These only test the description is included in the client-side payload sent to the server, they don't test that the server receives and stores the description; maybe adding a non-trivial description field to this test would do the trick: https://github.com/PrefectHQ/prefect/blob/main/tests/events/server/models/test_automations.py#L176
Adds the description to automations from triggers specified in the
prefect.yaml
.closes: #16655
Checklist
<link to issue>
"mint.json
.