Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version header to all client requests #1690

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add version header to all client requests #1690

merged 2 commits into from
Nov 1, 2019

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Oct 31, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds an informative header to all Cloud client requests: X-PREFECT-CORE-VERSION=<version>

Why is this PR important?

@jlowin jlowin requested review from cicdw and joshmeek as code owners October 31, 2019 20:00
@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #1690 into master will increase coverage by <.01%.
The diff coverage is 100%.

@cicdw cicdw merged commit b6d7668 into master Nov 1, 2019
@cicdw cicdw deleted the client-header branch November 1, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants