Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SnowflakeQuery task #1663

Merged
merged 13 commits into from
Oct 27, 2019
Merged

Fix for SnowflakeQuery task #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
add2fdb
documenting aws_session_token in fargate agent init method
Oct 8, 2019
1b352ee
fixed conflicts
Oct 10, 2019
6f954fb
Merge branch 'feature/fargate-agent'
Oct 10, 2019
a685601
Merge branch 'feature/fargate-agent'
Oct 10, 2019
c8bf064
Merge branch 'feature/fargate-agent'
Oct 14, 2019
cf327d5
Merge branch 'master' of https://github.com/PrefectHQ/prefect
Oct 16, 2019
7d4e323
Merge branch 'master' of https://github.com/PrefectHQ/prefect into fi…
Oct 26, 2019
2e57a80
fix for Snowflake query task
Oct 26, 2019
0817256
updated Changelog
Oct 26, 2019
b499212
positional arg
Oct 26, 2019
8ea71d1
fix test with positional arg
Oct 26, 2019
abb1fd6
update to snfk test
Oct 27, 2019
658787b
Merge branch 'master' into fix_snowflake_task
cicdw Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ These changes are available in the [master branch](https://github.com/PrefectHQ/
- Fix ShellTask return value on empty stdout - [#1632](https://github.com/PrefectHQ/prefect/pull/1632)
- Fix issue with some Cloud Secrets not being converted from strings - [#1655](https://github.com/PrefectHQ/prefect/pull/1655)
- Fix issue with Agent logging config setting not working - [#1657](https://github.com/PrefectHQ/prefect/pull/1657)
- Fix issue with SnowflakeQuery tasks not working - [#1663](https://github.com/PrefectHQ/prefect/pull/1663)

### Deprecations

Expand Down
2 changes: 1 addition & 1 deletion src/prefect/tasks/snowflake/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def run(self, query: str = None, data: tuple = None, autocommit: bool = None):
try:
with conn:
with conn.cursor() as cursor:
executed = cursor.execute(query=query, params=data)
executed = cursor.execute(query, params=data)

conn.close()
return executed
Expand Down