[typing] clean up prefect __init__.py #16451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
requested review from
aaazzam,
chrisguidry,
cicdw,
desertaxle and
zzstoatzz
as code owners
github-actions
bot
added
the
development
mjpieters
force-pushed
the
typing_prefect_init
branch
from
34faa7b to
7fce521
Compare
CodSpeed Performance ReportMerging #16451 will not alter performanceComparing Summary
|
|
This PR moves the type completeness needle by an astounding 0.053%! 🎉 🤯💥 |
mjpieters
force-pushed
the
typing_prefect_init
branch
from
7fce521 to
0cae31c
Compare
desertaxle
reviewed
Dec 19, 2024
mjpieters
force-pushed
the
typing_prefect_init
branch
3 times, most recently
from
23e89cd to
c32fa63
Compare
mjpieters
force-pushed
the
typing_prefect_init
branch
7 times, most recently
from
7f6e1a1 to
407c66a
Compare
- Provide more typing details for version info and the local module spec. - A module `__getattr__` is never called for globals, so the `_slots` structure was redundant. - For Python 3.10 and up, include more context in the AttributeError.
mjpieters
force-pushed
the
typing_prefect_init
branch
from
407c66a to
b8b5a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__getattr__is never called for globals, so the_slotsstructure was redundant.try: ... except:block.References #16292