Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redis causal ordering implementation #16416

Merged
merged 17 commits into from
Dec 18, 2024
Merged

Add redis causal ordering implementation #16416

merged 17 commits into from
Dec 18, 2024

Conversation

zangell44
Copy link
Collaborator

@zangell44 zangell44 commented Dec 17, 2024 •
edited
Loading

This PR adds a Redis based implementation of the CausalOrdering mechanism, allowing multiple replicas to coordinate ordered event processing.

This PR does not provide a mechanism for injecting this redis implementation in place of the existing one.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@zzstoatzz zzstoatzz mentioned this pull request Dec 17, 2024
Merged
@zzstoatzz zzstoatzz mentioned this pull request Dec 18, 2024
Open
@zangell44 zangell44 changed the title [WIP] Add redis causal ordering implementation Add redis causal ordering implementation Dec 18, 2024
@zangell44 zangell44 marked this pull request as ready for review December 18, 2024 22:29
desertaxle
desertaxle approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/integrations/prefect-redis/prefect_redis/ordering.py Outdated Show resolved Hide resolved
@zangell44 @desertaxle
Update src/integrations/prefect-redis/prefect_redis/ordering.py
7a7d7e5 
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
@zangell44 zangell44 merged commit 6ee1712 into main Dec 18, 2024
13 checks passed
@zangell44 zangell44 deleted the redis-ordering branch December 18, 2024 22:48
devinvillarosa pushed a commit that referenced this pull request Dec 19, 2024
@zangell44 @desertaxle @devinvillarosa
Add redis causal ordering implementation (#16416)
371c4f3 
Co-authored-by: Alexander Streed <desertaxle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zangell44 @desertaxle