-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks for active workers when deploying #15632
base: main
Are you sure you want to change the base?
Checks for active workers when deploying #15632
Conversation
CodSpeed Performance ReportMerging #15632 will not alter performanceComparing Summary
|
…in-deployment-to' of https://github.com/PrefectHQ/prefect into jean/oss-5686-do-not-provide-worker-setup-instructions-in-deployment-to
…structions-in-deployment-to
…in-deployment-to' of https://github.com/PrefectHQ/prefect into jean/oss-5686-do-not-provide-worker-setup-instructions-in-deployment-to
…structions-in-deployment-to
…structions-in-deployment-to
…in-deployment-to' of https://github.com/PrefectHQ/prefect into jean/oss-5686-do-not-provide-worker-setup-instructions-in-deployment-to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my stylistic comments, can you please add coverage for the changes to the prefect deploy
CLI and flow.deploy
? Also, looks like there's a .swp
file that snuck into this PR.
This PR adds code to check if a work pool has active workers when deploying a flow in order to not display irrelevant informantion to users with an existing setup. This check is added to the various methods for deploying a flow.
closes #15513
Checklist
<link to issue>
"mint.json
.