Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for active workers when deploying #15632

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Oct 9, 2024

This PR adds code to check if a work pool has active workers when deploying a flow in order to not display irrelevant informantion to users with an existing setup. This check is added to the various methods for deploying a flow.
closes #15513

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the enhancement An improvement of an existing feature label Oct 9, 2024
Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #15632 will not alter performance

Comparing jean/oss-5686-do-not-provide-worker-setup-instructions-in-deployment-to (6387a1b) with main (b7b79a4)

Summary

✅ 3 untouched benchmarks

src/prefect/flows.py Outdated Show resolved Hide resolved
@jeanluciano jeanluciano marked this pull request as ready for review October 16, 2024 15:15
src/prefect/cli/deploy.py Outdated Show resolved Hide resolved
…in-deployment-to' of https://github.com/PrefectHQ/prefect into jean/oss-5686-do-not-provide-worker-setup-instructions-in-deployment-to
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my stylistic comments, can you please add coverage for the changes to the prefect deploy CLI and flow.deploy? Also, looks like there's a .swp file that snuck into this PR.

src/prefect/cli/deploy.py Outdated Show resolved Hide resolved
src/prefect/deployments/runner.py Show resolved Hide resolved
src/prefect/flows.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not provide worker setup instructions in deployment to healthy work-pools
3 participants