Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update global concurrency limits docs for removed create_if_missing behavior #15517

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Update global concurrency limits docs for removed create_if_missing behavior #15517

merged 2 commits into from
Sep 27, 2024

Conversation

collincchoy
Copy link
Contributor

@collincchoy collincchoy commented Sep 27, 2024 •
edited
Loading

This PR tweaks global concurrency limits docs to account for recent changes from #15297 .

Before After
image image

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the docs label Sep 27, 2024
discdiver
discdiver approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@collincchoy collincchoy merged commit 05ec2b9 into main Sep 27, 2024
3 checks passed
@collincchoy collincchoy deleted the docs/concurrency-ctx-mgr-no-longer-creates-if-missing branch September 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@discdiver discdiver discdiver approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@collincchoy @discdiver @desertaxle