-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment client API to take an Union type for concurrency_limit
#15425
Update deployment client API to take an Union type for concurrency_limit
#15425
Conversation
…/oss-5398-update-deployment-apis-to-take-an-object-for
…/oss-5398-update-deployment-apis-to-take-an-object-for
CodSpeed Performance ReportMerging #15425 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I left a couple of nits on typing and dictionary key access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updates various client API related to creating and updating deployments to be able to take
Union[int,ConcurrencyLimitConfig]
. These changes can be summarized into:flow.deploy
,flow.serve
, and ourprefect.yaml
to take the union type.RunnerDeployment
creation methods to split aConcurrencyLimitConfig
into andint
andConcurrencyOption
. This is also done to the CLIdeploy
to support theprefect.yaml
Related: #14934
Checklist
<link to issue>
"mint.json
.