Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephemeral server start command for Windows #15421

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Sep 18, 2024

This is the same fix as #15103, but applied to the command used to start an ephemeral server.

I have verified the fix on a Windows 11 VM.

Closes #15414

@github-actions github-actions bot added the bug Something isn't working label Sep 18, 2024
@desertaxle desertaxle marked this pull request as ready for review September 18, 2024 18:03
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #15421 will not alter performance

Comparing fix-ephemeral-on-windows (dea9f92) with main (672104c)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ballmer would approve!

@desertaxle desertaxle merged commit 77f3405 into main Sep 18, 2024
35 checks passed
@desertaxle desertaxle deleted the fix-ephemeral-on-windows branch September 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report of issue with ephemeral server in Windows
2 participants