handle unnamed lambdas for consistency #15400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR reorders the validation to catch invalid
fn
name fallbacks before attempting to create the flow in the API, and renames afn
set to an unnamed lambda (which currently falls back to<lambda>
) tounknown-lambda
to handle this casebesides disallowing
<
and>
in names ofFlow
objects in the API, theflow
decorator just works with lambdas (though granted its not recommended) and IMO we should either handle this case or explicitly not support lambdas (which we do already use forfn
in the tests)before
after