Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oracledb support in prefect-sqlalchemy #15385

Merged

Conversation

Ben-Taarit
Copy link
Contributor

This pull request adds support for Oracle databases using the oracledb Python library in the Prefect SQLAlchemy integration, addressing issue #15278.

Overview of the proposed changes:

Added Oracle Support in Enums:

  • Added ORACLE_ORACLEDB to the SyncDriver enum, enabling synchronous connections to Oracle databases using the oracledb driver.
  • Added ORACLE_ORACLEDB_ASYNC to the AsyncDriver enum, enabling asynchronous connections to Oracle databases using the oracledb driver with SQLAlchemy's async support.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@desertaxle desertaxle merged commit b46c56c into PrefectHQ:main Sep 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants