Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note that deployments delegate ACLs to work pools #15383

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

abrookins
Copy link
Collaborator

@abrookins abrookins commented Sep 13, 2024

We've made a couple of changes to ACLs. This PR summarize them in the documentation on ACLs.

  1. Work pools now support ACLs.
  2. Deployments now delegate permission checks to their work pool if the work pool has ACLs configured. If the work pool doesn't have ACLs, the deployment's ACLs apply instead.

We're trying to test this feature carefully with individual accounts rather than roll it out globally to all Enterprise customers, so I've added the DON'T MERGE label until we decide to release this to the world.

Fixes ENTRP-77.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One nit for consistency.

….mdx

Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
@abrookins
Copy link
Collaborator Author

Thanks, @discdiver!

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

@abrookins
Copy link
Collaborator Author

@discdiver Now we're ready to merge this if you can take another look!

@discdiver discdiver self-requested a review October 3, 2024 15:10
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abrookins abrookins merged commit c3fc6bd into main Oct 3, 2024
6 checks passed
@abrookins abrookins deleted the work-pool-acls-docs branch October 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs DONT MERGE This PR shouldn't be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants