Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of implicit relative import when using safe_load_namespace #15358

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Sep 12, 2024

safe_load_namespace had trouble loading implicitly relative import (e.g. from constants import FOO) because the current working directory wasn't included in the sys path when attempting to resolve imports. This PR fixes that.

Closes #15352

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the bug Something isn't working label Sep 12, 2024
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, LGTM

Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #15358 will not alter performance

Comparing fix-implicit-relative-imports-safe-load (165a8df) with main (ed6d2d7)

Summary

✅ 3 untouched benchmarks

@desertaxle desertaxle merged commit 7ba1dd3 into main Sep 12, 2024
35 checks passed
@desertaxle desertaxle deleted the fix-implicit-relative-imports-safe-load branch September 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy with missing dependencies breaks when flow decorator uses an imported variable
3 participants