Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place Task logger in context earlier #1510

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Place Task logger in context earlier #1510

merged 2 commits into from
Sep 14, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 14, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds the Task logger in context within initialize_run instead of only during get_task_run_state. This ensures that the Task logger is available during every single pipeline step, including during cache validation.

Why is this PR important?

See #1509 for an excellent description of why having a properly populated context object is important.

Closes #1509

@cicdw cicdw merged commit 8ee79dd into master Sep 14, 2019
@cicdw cicdw deleted the more-context branch September 14, 2019 18:49
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make context Available to Cache Validator Functions
2 participants